-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes globalConfig to custom test sequencers #14535
Exposes globalConfig to custom test sequencers #14535
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a changelog entry as well? 🙂
sequencer = new TestSequencer({ | ||
contexts: [], | ||
globalConfig: {} as Config.GlobalConfig, | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is ideal, but since the Jest TestSequencer
doesn't use either contexts, or globalConfig, it should be fine to have stand ins here, for now.
Alternatively we could make TestSequencerOptions
optional, or even properly create contexts and globalConfig in the beforeEach.
lmk what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this test you can use
jest/packages/test-utils/src/config.ts
Line 131 in 0afd8f1
export const makeGlobalConfig = ( |
But it might need to be optional so it's not a breaking change (i.e. a newer version of @jest/test-scheduler
than the version of @jest/core
). However, I think the next release of Jest will be a major, in which case we don't need it to be optional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Adds a way for custom test sequencers to access the global config. This will allow ordering test suites by using the seed which I don't see an easy way to do currently.
Test plan
Added unit tests to check that we can use globalConfig values, namely
seed
, in a customTestSequencer.yarn jest e2e/__tests__/customTestSequencers.test.ts